fix: adjust test ui script in package's json #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arboleya
requested review from
Dhaiwat10,
Torres-ssf,
danielbate,
digorithm,
maschad,
nedsalk and
petertonysmith94
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3486 will degrade performances by 20.44%Comparing Summary
Benchmarks breakdown
|
nedsalk
approved these changes
Dec 17, 2024
Dhaiwat10
approved these changes
Dec 17, 2024
Contributor
|
Are these tests being run in the CI? |
Torres-ssf
approved these changes
Dec 17, 2024
danielbate
approved these changes
Dec 17, 2024
Contributor
Author
I don't think so, but will defer to @Dhaiwat10 @danielbate. @petertonysmith94 What is your concern? |
Contributor
The main concern would be shipping broken tests with the template. |
petertonysmith94
approved these changes
Dec 17, 2024
Contributor
|
Coverage Report:
Changed Files:
|
4 tasks
arboleya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test:uiinside newcreate fuelsapp #3480Checklist